I have 3 cards, showing my services and enabled them to act as links. I added an aria-label to each link when I set the links because I think that accessibility is very important these days. But they don’t show up in the code when exported. Nor does the automatically added title attribute.
Did I miss something? Is that Foundry 3 or rather a Stacks 5 issue? Google mocks me about that (Links do not have a discernible name).
Will need a project file to look at, it helps troubleshooting so I don’t have to try and exactly replicate everything you might have going on with a page. Provide that project file and I can take a look.
Sent you a pm with a link to the project file. Thanks for checking.
The link dialogue, where you’ve added your ARIA label (see below), can only add items to the code that have preset insert points inside the code for the link. This is just how the Stacks API works. I literally have no control over it.
For example, the underlying code for the link for the card is:
<a href="%id=card-link -href%" class="position-absolute w-100 h-100 t-0 start-0 %id=card-link -class%" rel="%id=card-link -rel%" target="%id=card-link -target%" onclick="%id=card-link -onclick%"></a>
As you scroll to the right in the code block above, you’ll see I’ve had to add preset insert points for class, rel, target and onclick. Those are the only things you can add via the link dialogue as they’re the only elements Stacks is thus providing insert points for.
You’ll notice, say in the Button tool for example, that I have a very specific section for ARIA accessibility links:
This isn’t present with the Card link. So it isn’t a bug that you’ve run into, just that it is not a feature. I will note it for a future update in some form or fashion.
No, that is not something Isaiah would change. He can’t automatically insert any and all tags a user inserts into the link dialogue. And probably shouldn’t.
As I said I have to make a preset entry for it, much like with target, rel, etc.
I noted above…
I either will add an entry for this link to support ARIA, or more likely I’ll do what is done with the Button tool.
Thanks for clearing that up, Adam!
For now I edited the anchor tags for the linked cards manually in the code to see where it’d get me, and it got me to 100% on accessibility. Didn’t touch the links in the footer area (linked list), that miss aria-labels too. Maybe google counts them at not so important because they are in a <footer> tag. Who knows. But might wanna keep an eye on those too if you think about adding aria support for more elements.
I used to work with handicapped people a lot, so I know how important accessibility is for them. Not only in the real world, but in the depths of the World Wide Web too.
So far, I’m very impressed with Foundry 3.
